Another workaround to changing themes to restore the Folder Colours it just to click on it to open the colours dialog box and close the box without making a selection. It then remembers what it should be set too,
One of my folders wasn't responding to this. It's latest folder in the project. remembering that I had saved the scene earlier, and without a colour selection being set to this folder. I tried again saving the scene after setting the folder colour. And now the folder behaves like the other. Opens without a colour, but can be recalled by changing the theme, or opening and closeing the colour dialog box and not making a selection.
Seems Scenes is connected to this.