I would expect the modification's effect to vary from one pickup/amp combination to another, which is probably why some people like it and others do not, and why the presenter elected to make it a temporary try-it-and-see solution. 
 

The volume control loads down the tone pot on most modern guitars. The early 57 Les Pauls and other,s swap a couple wires in the circuit so that the tone control loads the volume pot. You turn down the volume and the tone stays nice. You turn down the tone and the volume drops a bit.

The problem- the quest as a lead guitarist to define a smooth transition between back up fills and lead solos. 
I've tried this as well as every front end volume trick I could find. Volume pedals, Stomp boxes and yes using the volume control on the guitar. 
I use a none channel swicthing amp so I can't do that trick. But my conclution is the only way to keep the same tone and amount of overdrive is to change the master volume on my Princeton. 
Every other trick to lower the volume just kills your tone and sustain. 
So I'm looking into a volume pedal that takes over the amps master volume. SHouldn't be hard to do. 

If you want the same tone and overdrive at all volumes the "traditional" way is to use a big amp that doesn't overdrive easily and has lots of clean headroom. Twin reverbs and Hiwatts are two examples. Turn it up to where you need the clean volume to be then leave it alone.

Then use an overdrive or distortion that has quite a bit of compression, e.g. a tubescreamer or Big Muff followed by a volume pedal which effectively becomes your master volume.