Music theory is a tool - a fascinating tool if you like math and music - but it remains but one tool in a wide array of tools.
There are dozens of ways to learn scales. I teach my students the major scale as a pattern of half and whole steps (WWHWWWH) and then I move them to the circle of fifths. The combination seems to reinforce the concept of scale construction, and most of them rapidly reach the point where they can construct any major scale in their heads without any real effort.
Next I introduce the seven Greek modes. No, I'm still not sure why, but it seems to work for most students. Again we learn the pattern for each mode, and then we apply the circle of fifths again, although by this point most of them simply add these to their vocabulary.
And once they know the Aeolian mode they also know the natural minor scale. Adding the harmonic and melodic variations seems to come somewhat naturally from there.
Some of this is just plain brute memorization, but there are lots of patterns, some of which will make sense to some folks, while other folks will find different patterns.
Now let's see how well my pattern memory is working today - I've listed what I think are the more important scales, and the Greek modes below. I've included the number of sharps or flats, which scale tones are altered, whole and half steps, and the names of the notes starting on "C".
Major / Ionian 1 2 3 4 5 6 7CwDwEhFwGwAwBhCLydian1 [class="font5"]♯1 2 3 #4 5 6 7CwDwEwF#hGwAwBhCMelodic Minor (ascending)1 [class="font5"]♭1 [class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font0"]6 1617CwDh♭EwFwGwAwBhCMixo-Lydian1 [class="font5"]♭1 [class="font0"]2 [class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font0"]6 [class="font5"]♭3233CwDwEhFwGwAh♭BwCHarmonic Minor2 [class="font5"]♭1 [class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font5"]♭[class="font0"]6 5051CwDh♭EwFwGh♭AwhBhCDorian2 [class="font5"]♭1 2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font0"]6 [class="font5"]♭6667CwDh♭EwFwGwAh♭BwCNatural Minor /Aeolian3 [class="font5"]♭1 [class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭8687CwDh♭EwFwGh♭Aw♭BwCHalf Diminished4 [class="font5"]♭1 [class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font5"]♭[class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭108109CwDh♭EwFh♭Gw♭Aw♭BwCPhyrigian4 [class="font5"]♭1 [class="font5"]♭[class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭130131Ch♭Dw♭EwFwGh♭Aw♭BwCDiminshed / Locrian5 [class="font5"]♭1 [class="font5"]♭[class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font5"]♭[class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭154155Ch♭Dw♭EwFh♭Gw♭Aw♭BwCAltered6 [class="font5"]♭1 [class="font5"]♭[class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font5"]♭[class="font0"]4 [class="font5"]♭[class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭180181Ch♭Dw♭Eh♭Fw♭Gw♭Aw♭BwCSome folks prefer to think of the modes as "all the white keys starting on...", which is fine if you are used to the piano keyboard. Many of my students only play guitar, so I try not to emphasize white and black keys<G>!
Major / Ionian 1 2 3 4 5 6 7CwDwEhFwGwAwBhCDorian2 [class="font5"]♭1 2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font0"]6 [class="font5"]♭196197DwShFwGwAwBhCwDPhyrigian4 [class="font5"]♭1 [class="font5"]♭[class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭218219EhFwGwAwBhCwDwELydian1 [class="font5"]♯1 2 3 #4 5 6 7FwGwAwBhCwDwEhFMixo-Lydian1 [class="font5"]♭1 [class="font0"]2 [class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font0"]6 [class="font5"]♭236237GwAwBhCwDwEhFwGNatural Minor /Aeolian3 [class="font5"]♭1 [class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭256257AwBhCwDwEhFwGwADiminshed / Locrian5 [class="font5"]♭1 [class="font5"]♭[class="font0"]2 [class="font5"]♭[class="font0"]3 [class="font0"]4 [class="font5"]♭[class="font0"]5 [class="font5"]♭[class="font0"]6 [class="font5"]♭280281BhCwDwEhFwGwAwBThe other thing to memorize, or figure out anyway, is the circle of fifths, which looks way cooler in graphic form, but here it is in tabular format - with relative minor scales to boot!
C Major0A MinorG Major1 #E MinorD Major2 #B MinorA Major3 #F# MinorE Major4 #G♭MinorB Major5 #D♭MinorF# Major6 #A♭MinorG♭Major6♭E♭MinorD♭Major5♭B♭MinorA♭Major4♭F MinorE♭Major3♭C MinorB♭Major2♭G MinorF Major1♭D MinorThat ought to get you started<G>...
Bill